Delete now-unnecessary TR_Removed*Guard guard kinds#18624
Merged
dsouzai merged 1 commit intoeclipse-openj9:masterfrom Dec 27, 2023
Merged
Delete now-unnecessary TR_Removed*Guard guard kinds#18624dsouzai merged 1 commit intoeclipse-openj9:masterfrom
dsouzai merged 1 commit intoeclipse-openj9:masterfrom
Conversation
AOT now takes care of generating the TR_Inlined*Method relocations for inlined methods without corresponding guards, so we can remove guards without creating stand-ins.
Contributor
Author
|
This will need a coordinated merge with eclipse-omr/omr#7205 |
Contributor
Author
|
@dsouzai, could you please review? |
dsouzai
approved these changes
Dec 15, 2023
Contributor
|
Jenkins test sanity.functional+aot all jdk17,jdk21 depends eclipse-omr/omr#7205 |
Contributor
|
aarch64 failures due to #18436 the zlinux failure I'm not sure I've seen before, but it doesn't look like this change could cause it: |
Contributor
|
Jenkins test sanity.functional+aot zlinux jdk21 depends eclipse-omr/omr#7205 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AOT now takes care of generating the
TR_Inlined*Methodrelocations for inlined methods without corresponding guards, so we can remove guards without creating stand-ins.